• Psaldorn@lemmy.world
    link
    fedilink
    arrow-up
    33
    ·
    1 month ago

    Merging failing tests so everybody else has failing tests and wastes time figuring out why.

    Nothing neutral here

      • Psaldorn@lemmy.world
        link
        fedilink
        arrow-up
        8
        ·
        1 month ago

        If I rebase my branch with main I do not expect any failing tests. If you waste my time merging shit code, fuck you. Fix your shit.

        Unless prod is on fire and the CEO is prowling (even then, I’d argue standards should be maintained)

        • RamblingPanda@lemmynsfw.com
          link
          fedilink
          arrow-up
          5
          ·
          1 month ago

          I don’t say this is good practice, you shouldn’t even be able to merge to main with failing tests. I’ve implemented an emergency flag to do this, but I don’t want to use it in normal, daily business.